Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation for timezone of azurerm_automation_schedule #7754

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Jul 15, 2020

fixes #7735

After checked, seems api behavior has been changed. Currently seems timezone display name isn't supported anymore. We have to use timezone value. Get more available timezone list via https://s2.automation.ext.azure.com/api/Orchestrator/TimeZones?_=1594792230258
So I made a fix for this issue.

image

@ghost ghost added size/XL and removed size/M labels Jul 16, 2020
@jackofallops jackofallops added this to the v2.19.0 milestone Jul 16, 2020
@jackofallops
Copy link
Member

Tests passing:
image

@jackofallops jackofallops merged commit e9cc37a into hashicorp:master Jul 16, 2020
jackofallops added a commit that referenced this pull request Jul 16, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_automation_schedule does not set timezone correctly
2 participants