dependencies: updating to v44.0.0 of github.com/Azure/azure-sdk-for-go #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
approved these changes
Jul 10, 2020
| @@ -311,7 +311,9 @@ func resourceArmBlueprintAssignmentDelete(d *schema.ResourceData, meta interface | |||
| name := assignmentID.Name | |||
| targetScope := assignmentID.Scope | |||
|
|
|||
| resp, err := client.Delete(ctx, targetScope, name) | |||
| // We use none here to align the previous behaviour of the blueprint resource | |||
| // TODO: we could add a features flag for the blueprint to empower terraform when deleting the blueprint to delete all the generated resources as well | |||
There was a problem hiding this comment.
I think we should remove this as it may or may not actually be a good idea according to @jackofallops
Suggested change
| // TODO: we could add a features flag for the blueprint to empower terraform when deleting the blueprint to delete all the generated resources as well |
katbyte
added a commit
that referenced
this pull request
Jul 10, 2020
katbyte
pushed a commit
that referenced
this pull request
Jul 10, 2020
The machine learning service has changed the delete from a sync operation to an async operation. Depends on the SDK v44.0.0 PR #7616
|
This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.19.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by the customer requirement of BlackRock and another RP onboard of hardware security modules