Added new 0.1 version to WAF managed_rule_set to support Microsoft_BotManagerRuleSet creation

[wlodekj]

Hey,

This is my first PR here. I wanted to fix an issue with Microsoft_BotManagerRuleSet version 0.1 not being supported in azurerm_web_application_firewall_policy.managed_rules.managed_rule_set. Currently accepted version numbers are:

var ValidateWebApplicationFirewallPolicyRuleSetVersion = validation.StringInSlice([]string{
	"1.0",
	"2.2.9",
	"3.0",
	"3.1",
}, false)

It looks like a Microsoft thing - they have recently changed version 1.0 to 0.1... Added 0.1 version and updated doc files. Not sure if this validation makes sense here, maybe it's better to provide just a full rule name without type and version and be less strict about it?

• https://docs.microsoft.com/en-us/azure/web-application-firewall/ag/bot-protection-overview (new 0.1)
• https://azure.microsoft.com/en-us/updates/new-bot-protection-rule-set-in-public-preview-for-web-application-firewall-waf-with-azure-front-door-service/ (old 1.0 reference)

Thanks,
Jakub

[tombuildsstuff]

hey @wlodekj

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can add 1.0 back in then this otherwise LGTM 👍

Thanks!

[wlodekj]

Hey @tombuildsstuff,

Reverted back 1.0 and update docs.

Thanks!
Jakub

[tombuildsstuff]

LGTM - thanks for pushing those changes @wlodekj

[ghost]

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!