-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update azurerm_eventhub_namespace with optional dedicated_cluster_id #7548
Update azurerm_eventhub_namespace with optional dedicated_cluster_id #7548
Conversation
@tombuildsstuff @jackofallops here we go again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @favoretti
Thanks for splitting this back out :)
I've taken a look through and left some comments inline, but this is mostly looking good so far. To reply to your question:
I would really appreciate a couple of pointers on how you want me to implement validation for limits in azurerm_eventhub depending on a property of azurerm_eventhub_namespace.
In this instance since these fields can both be set, albeit to different maximum values - unfortunately we don't support conditional validation yet so we'll be best to increase the maximum value of the validation to the maximum (e.g. where Dedicated is higher) and then add a yellow "information" box (~> **Note:** Lorem Ipsum..
) to call that out in the documentation; potentially making a check inside the Create/Update function to check that those are within the expected bounds when not using a a Dedicated Cluster. Hopefully that makes sense?
Thanks!
azurerm/internal/services/eventhub/eventhub_namespace_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventhub/eventhub_namespace_resource.go
Outdated
Show resolved
Hide resolved
…rce.go Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
Co-authored-by: Tom Harvey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @favoretti
This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.18.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Update
azurerm_eventhub_namespace
with optionaldedicated_cluster_id
property.