Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sql_firewall_rule: TLS minimal version support for AzureSQL server #7295

Closed
Quantalian opened this issue Jun 11, 2020 · 5 comments · Fixed by #8361
Closed

azurerm_sql_firewall_rule: TLS minimal version support for AzureSQL server #7295

Quantalian opened this issue Jun 11, 2020 · 5 comments · Fixed by #8361
Assignees
Labels
enhancement service/mssql Microsoft SQL Server
Milestone

Comments

@Quantalian
Copy link

Quantalian commented Jun 11, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

AzureRM Provider Version

  • 2.4.0

Description

After Azure latest update for App Registration 'TLS minimal version' is required in Azure SQL server firewall rules if you are using Msal.js <= 1.0 for Single Page Application.

Expected behavior

ssl_minimal_tls_version = "TLS1_2"

Actual behavior

not supported, need to define it from portal after terraform apply

New or Affected Resource(s)

  • azurerm_sql_firewall_rule

References

@mybayern1974 mybayern1974 added the service/mssql Microsoft SQL Server label Jun 12, 2020
@manicminer manicminer self-assigned this Sep 4, 2020
@katbyte katbyte added this to the v2.31.0 milestone Oct 2, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@HarleyB123
Copy link
Contributor

Hey 👋

Whilst this has been solved for azurerm_mssql_server, it would be really cool if this same sort of implementation was available for azurerm_sql_server

Will try and make a PR for this myself, though my Go is sketchy and would be copying the great work already done in the mssql PR :)

@dhirschfeld
Copy link
Contributor

Hi @HarleyB123 👋
Just wondering why you wouldn't simply port to azurerm_mssql_server since they spin up the same infrastructure?

Even though it's not apparently documented anywhere, from my inquiry azurerm_sql_server is effectively a deprecated api which has been superseded by azurerm_mssql_server: #8338 (comment)

@HarleyB123
Copy link
Contributor

Thanks @dhirschfeld , I agree that documentation would be beneficial on this as I thought they were two separate resources too! :)

Will port over to azurerm_mssql_server

@ghost
Copy link

ghost commented Nov 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/mssql Microsoft SQL Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants