azurerm_shared_image & azurerm_shared_image_version - support for specialized images by setting generalized to false

[ArcturusZhang]

This PR adds support for the specialized shared image, with the following changes:

• azurerm_shared_image - add os_state attribute to indicate this image definition is generalized or specialized.
• azurerm_shared_image_version - add os_disk_snapshot_id attribute to support create new image version using snapshot, which also enables you create new version for a specialized image.

[ArcturusZhang]

Tests are passing:

=== RUN   TestAccAzureRMSharedImageVersion_basic
=== PAUSE TestAccAzureRMSharedImageVersion_basic
=== CONT  TestAccAzureRMSharedImageVersion_basic
--- PASS: TestAccAzureRMSharedImageVersion_basic (2421.21s)
=== RUN   TestAccAzureRMSharedImageVersion_storageAccountTypeLrs
=== PAUSE TestAccAzureRMSharedImageVersion_storageAccountTypeLrs
=== CONT  TestAccAzureRMSharedImageVersion_storageAccountTypeLrs
--- PASS: TestAccAzureRMSharedImageVersion_storageAccountTypeLrs (1294.24s)
=== RUN   TestAccAzureRMSharedImageVersion_storageAccountTypeZrs
=== PAUSE TestAccAzureRMSharedImageVersion_storageAccountTypeZrs
=== CONT  TestAccAzureRMSharedImageVersion_storageAccountTypeZrs
--- PASS: TestAccAzureRMSharedImageVersion_storageAccountTypeZrs (1212.54s)
=== RUN   TestAccAzureRMSharedImageVersion_specializedImageVersion
=== PAUSE TestAccAzureRMSharedImageVersion_specializedImageVersion
=== CONT  TestAccAzureRMSharedImageVersion_specializedImageVersion
--- PASS: TestAccAzureRMSharedImageVersion_specializedImageVersion (1087.86s)
=== RUN   TestAccAzureRMSharedImageVersion_requiresImport
=== PAUSE TestAccAzureRMSharedImageVersion_requiresImport
=== CONT  TestAccAzureRMSharedImageVersion_requiresImport
--- PASS: TestAccAzureRMSharedImageVersion_requiresImport (1509.59s)
PASS

[katbyte]

@ArcturusZhang - i am getting test failures on TC:

TestAccAzureRMSharedImageVersion_requiresImport
TestAccDataSourceAzureRMSharedImageVersion_basic
TestAccDataSourceAzureRMSharedImageVersion_latest
TestAccDataSourceAzureRMSharedImageVersion_recent
TestAccDataSourceAzureRMSharedImageVersions_basic
TestAccDataSourceAzureRMSharedImageVersions_tagsFilter

[ArcturusZhang]

Hi @katbyte I have synced with master... and now the tests seem passing

Interesting that first time one test fails, and second time I only run that failed test, and it passes.

[katbyte]

After some internal discussion could we rename this to generalized = bool ? this is at heart a boolean true/false and os_state really doesn't convey what its doing.

[ArcturusZhang]

Great idea! I will take care of this.

[ArcturusZhang]

Hi @katbyte I have resolved your comments, please have a look, thanks

[katbyte]

Thanks @ArcturusZhang, LGTM 👍

[katbyte]

Aside from 2 minor documentation changes which i will make now this LGTM 👍

[ghost]

This has been released in version 2.17.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.17.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!