-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Function support for Event Grid event subscription #7182
Azure Function support for Event Grid event subscription #7182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jrauschenbusch
Thanks for this PR :)
Taking a look through this is looking good - if we can can fix up the comments (and add an acceptance test) then we should be able to kick off the tests and get this merged 👍
Thanks!
azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/eventgrid/eventgrid_event_subscription_resource.go
Outdated
Show resolved
Hide resolved
@@ -91,6 +92,30 @@ func resourceArmEventGridEventSubscription() *schema.Resource { | |||
Computed: true, | |||
}, | |||
|
|||
"azure_function_endpoint": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add an acceptance test covering this new block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to do an acceptance test for it. Unfortunately, it's pretty much the same as the webhook endpoint, which is also hard to test. You would first have to be able to deploy a function with an input binding of type eventGridBinding
out of Terraform. But that is currently not possible as there is no terraform resource for it. It is only possible to deploy a function app, which hosts multiple functions inside.
I started with an implementation of an azurerm_function
resource to also be able to write acceptance tests for the function and webhook endpoints of the eventgrid_event_subscription
, but it's not that easy to find a good schema design for it.
@tombuildsstuff Changed everything except the missing acc test. Maybe i can add it by introducing another resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jrauschenbusch
Thanks for pushing those changes - taking a look through this now LGTM 👍
Thanks!
This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.14.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes #7176
Adds Azure Function support to
azurerm_eventgrid_event_subscription
resource.