Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: Data Factory Linked Service Key Vault Resource #6971

Merged
merged 2 commits into from
Jun 5, 2020
Merged

New Resource: Data Factory Linked Service Key Vault Resource #6971

merged 2 commits into from
Jun 5, 2020

Conversation

pearcec
Copy link
Contributor

@pearcec pearcec commented May 17, 2020 •
edited by tombuildsstuff
Loading

tombuildsstuff
tombuildsstuff reviewed May 18, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @pearcec

Thanks for this PR - taking a look through I've left a couple of comments inline but this is otherwise looking good 👍

Thanks!

website/docs/r/data_factory_linked_service_key_vault.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/datafactory/data_factory_linked_service_key_vault_resource.go Show resolved Hide resolved
@pearcec pearcec changed the title New Feature: Data Factory Linked Service Key Vault Resource New Resource: Data Factory Linked Service Key Vault Resource May 18, 2020
@pearcec
Copy link
Contributor Author

pearcec commented May 18, 2020

@tombuildsstuff fixed, take a look when you are able.

@ghost ghost removed the waiting-response label May 18, 2020
tombuildsstuff
tombuildsstuff approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @pearcec

Thanks for pushing those changes - taking a look through this LGTM 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-06-05 at 18 21 41

@tombuildsstuff tombuildsstuff added this to the v2.14.0 milestone Jun 5, 2020
@tombuildsstuff tombuildsstuff merged commit 104cf71 into hashicorp:master Jun 5, 2020
tombuildsstuff added a commit that referenced this pull request Jun 5, 2020
@tombuildsstuff
updating to include #6971
1e6486c
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/data-factory size/XL
Projects
None yet
Milestone
v2.14.0
Development

Successfully merging this pull request may close these issues.

Support for azurerm_data_factory_linked_service_key_vault
2 participants
@pearcec @tombuildsstuff