Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type PipelineReference in trigger resource #6871

Merged
merged 1 commit into from
May 12, 2020
Merged

Add type PipelineReference in trigger resource #6871

merged 1 commit into from
May 12, 2020

Conversation

sdebruyn
Copy link
Contributor

When the type is omitted, the trigger cannot be activated.

This fixes #6869 which has more details about the bug and why this PR is needed.

When the type is omitted, the trigger cannot be activated. This fixes #6869
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @sdebruyn 👍

@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 12, 2020
@tombuildsstuff
Copy link
Contributor

Ignoring one known failing test - the tests look good:

Screenshot 2020-05-12 at 15 25 27

@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field pipelineReference missing in Data Factory triggers
2 participants