-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading to v12.2.0-beta of the Azure SDK for Go #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
That was quick, thanks for the upgrade. |
@dominik-lekse alas this is only the first part - once this PR is merged I'll switch over to the versioned (e.g. not deprecated) SDK and then we should be good :) |
As far as I understood, the switch over to the versioned part of the SDK will be done per resource, right? |
Tests look good - so I'm going to merge this to continue with part 2 @dominik-lekse probably, given the |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This is the first phase of upgrading to the Azure SDK for Go v12.2.0-beta. Once this is merged we can start moving Data Sources and Resources off the Deprecated SDKs and over to the versioned SDKs
Upgrades to:
8bdf7d1a087ccc975cf37dd6507da50698fd19ca
of marstr/guid (new dependency from the Go SDK)