Add health_check_path to site_config

[sirlatrom]

Fixes #6429.

[sirlatrom]

@katbyte This should solve #6429. I've added an acceptance test that should pass as well. I've verified the functionality on my org's tenant, but cannot run acceptance tests due to restrictive permissions with regard to creating resource groups.

[katbyte]

Thanks for the pr @sirlatrom,

this LGTM except for the docs need to be updated. Once thats done this should be good to merge! 👍

[sirlatrom]

@katbyte I've added docs in 100e193. As a side note, I see some attributes are missing from the docs for the azurerm_app_service_slot page although they share the same schema for several sub-resources such as site_config, but I don't suppose adding those should be a requirement for this PR to be merged.

[tombuildsstuff]

one minor thing but this otherwise LGTM 👍

[tombuildsstuff]

in general we need to set a value for every key inside a dictionary, which helps us catch when Azure doesn't return a value from the API (otherwise Terraform Core will show a diff between "null" and "empty") e.g.

Suggested change

	}
	healthCheckPath := ""
	if input.HealthCheckPath != nil {
	healthCheckPath = *input.HealthCheckPath
	}
	result["health_check_path"] = healthCheckPath

however since the rest of this class doesn't, we can ignore this for now

[sirlatrom]

The API explicitly supports null as the value for this field, so I assumed that was what not setting the field would represent.

[sirlatrom]

FWIW I can change the above to explicitly set result["health_check_path"] = nil when input.HealthCheckPath == nil if that is supported.

[jackofallops]

Failures are transient on Azure side

[ghost]

This has been released in version 2.9.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.9.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!