azurerm_monitor_diagnostic_setting - mark retention_policy & retention_policy as optional

[nyuen]

modifying the Diagnostic settings schema to set the retention policy to Optional #5673

Some resources such as ActivityLogs do not support Retention Policy causing a change on subsequent Terraform apply even if the diagnostic setting. This is caused by a mismatch between the TFState and the object returned by the REST API

[katbyte]

Hi @nyuen, thanks for this PR!

overall looks good but could we update the website? thanks!

[katbyte]

Hey @nyuen, i hope you don't mind by i've pushed the required changes 🙂 LGTM 👍

[nyuen]

thanks @katbyte, looks like the linter failed, I guess len(policiesRaw) != 0 should be sufficient.
One a side note do you have more inputs one how the tests are run? I've tried to added a failing this and go test monitor resource_arm_monitor_diagnostic_setting_test.go still passed somehow.

[katbyte]

heh thats why we have linters 🙂 - and sadly the api can returninconsistentt results depending on many things including region and timing. pushed a commit which should fix that up

[ghost]

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!