Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator 'GeoMatch' for azurerm_web_application_firewall_policy is missing #6581

Closed
MaxiPalle opened this issue Apr 22, 2020 · 4 comments
Closed

Comments

@MaxiPalle
Copy link

MaxiPalle commented Apr 22, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.24

  • provider.azurerm v2.6.0

Affected Resource(s)

  • azurerm_web_application_firewall_policy

Terraform Configuration Files

resource "azurerm_web_application_firewall_policy" "default" {
  name                  = "${var.identifier}-${lower(var.environment)}-gatewaywafdefaultpolicy"
  resource_group_name   = var.rg_name
  location              = var.rg_location

  custom_rules {
    name      = "blockBlacklistedCountries"
    priority  = 1
    rule_type = "MatchRule"

    match_conditions {
      match_variables {
        variable_name = "RemoteAddr"
      }

      operator           = "GeoMatch"
      negation_condition = false
      match_values       = ["AA", "BB", "XY", "YY", "ZZ"]
    }

    action = "Block"
  }
}

Expected behaviour

Custom Application Gateway WAF rule should have been created.

Actual behaviour

Error: expected custom_rules.0.match_conditions.0.operator to be one of [IPMatch Equal Contains LessThan GreaterThan LessThanOrEqual GreaterThanOrEqual BeginsWith EndsWith Regex], got GeoMatch

  on main.tf line 156, in resource "azurerm_web_application_firewall_policy" "default":
 156: resource "azurerm_web_application_firewall_policy" "default" {

Steps to Reproduce

  1. terraform apply

References

https://www.terraform.io/docs/providers/azurerm/r/web_application_firewall_policy.html

@boschcrank
Copy link
Contributor

Here is a one-line PR to fix the issue: #7181

@boschcrank
Copy link
Contributor

I have no idea why this is not closed, but the issue is fixed in v2.14.0.

@tombuildsstuff
Copy link
Contributor

Closing since this has been fixed in v2.14 - thanks for the heads up @boschcrank

@ghost
Copy link

ghost commented Sep 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants