Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source azurerm_private_dns_zone #6512

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Apr 17, 2020

Fixes #6325

@manicminer manicminer requested a review from a team April 17, 2020 08:13
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.7.0 milestone Apr 20, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-04-20 at 11 24 57

@tombuildsstuff tombuildsstuff merged commit 1c6e0e1 into master Apr 21, 2020
@tombuildsstuff tombuildsstuff deleted the d/private-dns-zone branch April 21, 2020 07:12
tombuildsstuff added a commit that referenced this pull request Apr 21, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Private DNS Data Source
2 participants