Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HyperVGeneration attribute for shared_image #6511

Merged
merged 4 commits into from
Apr 23, 2020

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Apr 17, 2020

  • Adds attribute to azurerm_shared_image resource and data.azurerm_shared_image
  • Workaround for consistency issue when deleting shared images (by @neil-yechenwei )

References #6495
Fixes #6316

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

website/docs/r/shared_image.html.markdown Outdated Show resolved Hide resolved
website/docs/d/shared_image.html.markdown Outdated Show resolved Hide resolved
@manicminer manicminer force-pushed the r/shared-image/hyperv-generation branch from f896372 to 05e6882 Compare April 23, 2020 12:10
@manicminer
Copy link
Contributor Author

Tests pass

Screenshot 2020-04-23 14 36 09

@manicminer manicminer merged commit d2aa827 into master Apr 23, 2020
manicminer added a commit that referenced this pull request Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 23, 2020
@tombuildsstuff tombuildsstuff deleted the r/shared-image/hyperv-generation branch August 21, 2020 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute missing from resource azurerm_shared_image
2 participants