-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_route - add validation to routing table name and route name (#6053) #6055
azurerm_route - add validation to routing table name and route name (#6053) #6055
Conversation
I've pulled in the latest master changes which fix the linting issues |
…vider-azurerm into yves-vogl/fix-6053
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yves-vogl
Many thanks for the PR, good spot on the source of the issue!
I've made a couple of suggestions for an alternative implementation for the validation, could you check they meet your understanding of the naming limitations/requirements and commit if you're happy?
Thanks
Co-Authored-By: Steve <[email protected]>
Co-Authored-By: Steve <[email protected]>
Thanks for the suggestions! I really appreciate them. I accepted the suggestions and now are waiting for tests to complete. |
Please do not close the PR - I encountered the same issue for SecurityGroupRules and we'd like to fix it, too.
|
Hi @yves-vogl - Probably best to PR that change separately. I'll check this over and try to get it merged for the the 2.7 release later today. |
This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.7.0"
}
# ... other configuration ... |
I encountered the same issue for Subnet. Error: Error Creating/Updating Subnet "1.0.1.0/24-subnet" (Virtual Network "web-server-vnet" / Resource Group "web-rg"): network.SubnetsClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="Failed" Message="The async operation failed." AdditionalInfo=[{"Message":"No HTTP resource was found that matches the request URI 'https://southindia.network.azure.com:30114/redacted/redacted/subscriptions/redacted/resourceGroups/web-rg/providers/Microsoft.Network/virtualNetworks/web-server-vnet/subnets/1.0.1.0/24-subnet?api-version=2019-09-01'."}] |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Hi,
I'm trying to fix the issue I stumbled upon (#6053). Hope that helps.
Yves
Edit: Fixes #6053