Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - allow up to 50 tags #5934

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Feb 28, 2020

No description provided.

@katbyte katbyte added this to the v2.1.0 milestone Feb 28, 2020
@katbyte katbyte requested a review from a team February 28, 2020 00:10
@ghost ghost added the size/M label Feb 28, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one item for consideration that would also resolve the Travis failure, but otherwise LGTM 👍

@@ -543,6 +533,8 @@ func resourceArmStorageAccount() *schema.Resource {
Computed: true,
Sensitive: true,
},

"tags": tags.Schema(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage account tags are still more limited (length) than other resources, we might want to add a specific schema to the tags package that still uses validateAzureRMStorageAccountTags and update that to the 50 count?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, good catch! thx

@katbyte katbyte merged commit 9d147dc into master Feb 28, 2020
@katbyte katbyte deleted the kt/storage-gets-more-tags branch February 28, 2020 20:04
katbyte added a commit that referenced this pull request Feb 28, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants