Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_logic_app_workflow - expose computed field: endpoint_configuration #5862

Merged
merged 5 commits into from
Mar 18, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 24, 2020

This fix #5849

image

@magodo
Copy link
Collaborator Author

magodo commented Mar 11, 2020

@katbyte would you please review my latest comment?

@ghost ghost removed the waiting-response label Mar 11, 2020
"connector": buildFlowEndpointsSchema(),
},
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same here) these'll want to become top-level fields rather than nested within blocks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Tom, make sense to flatten that. Also thanks to remind me we should use TypeList for computed collections for better user experience.

@tombuildsstuff tombuildsstuff removed the request for review from katbyte March 16, 2020 13:28
@magodo magodo force-pushed the logic_app_new_field branch from 85762f1 to 95c2dad Compare March 17, 2020 02:42
@magodo magodo requested a review from katbyte March 17, 2020 02:45
@magodo
Copy link
Collaborator Author

magodo commented Mar 17, 2020

Thank you for the comment, I updated the code accordingly, please take a look.

💤  terraform-provider-azurerm [logic_app_new_field] make testacc TEST="./azurerm/internal/services/logic/tests" TESTARGS="-run='TestAcc(DataSource)?AzureRMLogicAppWorkflow_(basic|empty)'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/logic/tests -v -run='TestAcc(DataSource)?AzureRMLogicAppWorkflow_(basic|empty)' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceAzureRMLogicAppWorkflow_basic
=== PAUSE TestAccDataSourceAzureRMLogicAppWorkflow_basic
=== RUN   TestAccAzureRMLogicAppWorkflow_empty
=== PAUSE TestAccAzureRMLogicAppWorkflow_empty
=== CONT  TestAccDataSourceAzureRMLogicAppWorkflow_basic
=== CONT  TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (163.76s)
--- PASS: TestAccDataSourceAzureRMLogicAppWorkflow_basic (167.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/logic/tests 167.078s

@ghost ghost removed the waiting-response label Mar 17, 2020
@katbyte katbyte changed the title Logic app workflow expose computed field: endpoint_configuration azurerm_logic_app_workflow - expose computed field: endpoint_configuration Mar 18, 2020
@katbyte katbyte added this to the v2.2.0 milestone Mar 18, 2020
@katbyte katbyte merged commit 9c4deb4 into hashicorp:master Mar 18, 2020
katbyte added a commit that referenced this pull request Mar 18, 2020
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.2.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic App support outgoing ip addresses in the resources
3 participants