-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_logic_app_workflow - expose computed field: endpoint_configuration
#5862
Conversation
azurerm/internal/services/logic/data_source_logic_app_workflow.go
Outdated
Show resolved
Hide resolved
@katbyte would you please review my latest comment? |
"connector": buildFlowEndpointsSchema(), | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same here) these'll want to become top-level fields rather than nested within blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Tom, make sense to flatten that. Also thanks to remind me we should use TypeList
for computed collections for better user experience.
85762f1
to
95c2dad
Compare
Thank you for the comment, I updated the code accordingly, please take a look. 💤 terraform-provider-azurerm [logic_app_new_field] make testacc TEST="./azurerm/internal/services/logic/tests" TESTARGS="-run='TestAcc(DataSource)?AzureRMLogicAppWorkflow_(basic|empty)'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/logic/tests -v -run='TestAcc(DataSource)?AzureRMLogicAppWorkflow_(basic|empty)' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccDataSourceAzureRMLogicAppWorkflow_basic
=== PAUSE TestAccDataSourceAzureRMLogicAppWorkflow_basic
=== RUN TestAccAzureRMLogicAppWorkflow_empty
=== PAUSE TestAccAzureRMLogicAppWorkflow_empty
=== CONT TestAccDataSourceAzureRMLogicAppWorkflow_basic
=== CONT TestAccAzureRMLogicAppWorkflow_empty
--- PASS: TestAccAzureRMLogicAppWorkflow_empty (163.76s)
--- PASS: TestAccDataSourceAzureRMLogicAppWorkflow_basic (167.06s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/logic/tests 167.078s |
endpoint_configuration
endpoint_configuration
This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.2.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This fix #5849