Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/network_interface_application_security_group_association: removing ip_configuration_name #5815

Merged
merged 5 commits into from
Feb 20, 2020

Conversation

tombuildsstuff
Copy link
Contributor

There's been a breaking behavioural change in the Networking API where all IPv4 IP Configurations are now required to share the same Application Security Group - as such this PR updates this resource to account for this no longer being tied to a specific IP Configuration.

Fixes #5591

@tombuildsstuff tombuildsstuff force-pushed the b/application-security-group branch from 3dcb231 to 82c7e70 Compare February 19, 2020 11:15
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost added size/XL and removed size/L labels Feb 20, 2020
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2020-02-20 at 10 54 47

@tombuildsstuff tombuildsstuff merged commit 1ec1612 into master Feb 20, 2020
@tombuildsstuff tombuildsstuff deleted the b/application-security-group branch February 20, 2020 09:56
tombuildsstuff added a commit that referenced this pull request Feb 20, 2020
@yves-vogl
Copy link
Contributor

Thanks!

@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_network_interface - multiple IP Configurations fail with ASG associations
3 participants