Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/automation_schedule - adding validation for the timezone field #5759

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

jackofallops
Copy link
Member

No description provided.

@jackofallops jackofallops added this to the v2.0.0 milestone Feb 14, 2020
@ghost ghost added the size/L label Feb 14, 2020
@jackofallops jackofallops self-assigned this Feb 19, 2020
@jackofallops jackofallops modified the milestones: v2.0.0, v2.1.0 Feb 19, 2020
@jackofallops jackofallops requested a review from a team February 19, 2020 07:25
@jackofallops jackofallops changed the title removed deprected schema entry. Added timezone string validation Added timezone string validation Feb 19, 2020
@jackofallops jackofallops force-pushed the r/two-oh-todo-automation branch from 05fe2d5 to 3ba9ee0 Compare February 19, 2020 07:31
@ghost ghost added size/M and removed size/L labels Feb 19, 2020
@jackofallops jackofallops changed the title Added timezone string validation WIP: Added timezone string validation Feb 19, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff modified the milestones: v2.1.0, v2.2.0 Mar 10, 2020
@jackofallops jackofallops force-pushed the r/two-oh-todo-automation branch from 3ba9ee0 to b723710 Compare March 17, 2020 10:25
@jackofallops jackofallops changed the title WIP: Added timezone string validation Added timezone string validation Mar 18, 2020
@katbyte katbyte modified the milestones: v2.2.0, v2.3.0 Mar 18, 2020
@tombuildsstuff tombuildsstuff merged commit a720427 into master Mar 19, 2020
@tombuildsstuff tombuildsstuff deleted the r/two-oh-todo-automation branch March 19, 2020 07:42
@tombuildsstuff tombuildsstuff changed the title Added timezone string validation r/automation_schedule - adding validation for the timezone field Mar 19, 2020
tombuildsstuff added a commit that referenced this pull request Mar 19, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants