Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Windows image sysprep for image acctests #5661

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

jackofallops
Copy link
Member

No description provided.

@jackofallops jackofallops added this to the v1.44.0 milestone Feb 10, 2020
@jackofallops jackofallops requested a review from a team February 10, 2020 16:11
@jackofallops jackofallops self-assigned this Feb 10, 2020
@ghost ghost added the size/S label Feb 10, 2020
@jackofallops
Copy link
Member Author

The travis build failure's unrelated and has been fixed via #5669

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops force-pushed the f/fix-windows-vm-image-tests branch from db19871 to aa6781d Compare February 12, 2020 13:20
@ghost ghost added size/M and removed size/XXL labels Feb 12, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v1.44.0, v2.0.0 Feb 12, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit f0ee98e into master Feb 13, 2020
@tombuildsstuff tombuildsstuff deleted the f/fix-windows-vm-image-tests branch February 13, 2020 09:26
tombuildsstuff added a commit that referenced this pull request Feb 13, 2020
@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants