Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: 'azurerm_eventgrid_topic' #5367

Merged
merged 6 commits into from
Jan 15, 2020

Conversation

jackbatzner
Copy link
Contributor

Expose the 'azurerm_eventgrid_topic' resource as a data source

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Brunhil,

Thanks for the data source, in additional to one minor comment it appears the tests are failing:

Test Failed

------- Stdout: -------
=== RUN   TestAccDataSourceAzureRMEventGridTopic_basic
=== PAUSE TestAccDataSourceAzureRMEventGridTopic_basic
=== CONT  TestAccDataSourceAzureRMEventGridTopic_basic
--- FAIL: TestAccDataSourceAzureRMEventGridTopic_basic (0.27s)
    testing.go:569: Step 0 error: config is invalid: Reference to undeclared resource: A managed resource "azurerm_event_grid_topic" "test" has not been declared in the root module.

Jack Batzner added 2 commits January 14, 2020 11:57
- Fix ordering of properties
- Validate' name' property
- Fix acceptance test
@jackbatzner
Copy link
Contributor Author

Fixes pushed and verified tests run!

Event Grid Topic Data Source

=== RUN   TestAccDataSourceAzureRMEventGridTopic_basic
=== PAUSE TestAccDataSourceAzureRMEventGridTopic_basic
=== CONT  TestAccDataSourceAzureRMEventGridTopic_basic
--- PASS: TestAccDataSourceAzureRMEventGridTopic_basic (245.73s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests     246.001s

Event Grid Topic Resource

=== RUN   TestAccAzureRMEventGridTopic_basic
=== PAUSE TestAccAzureRMEventGridTopic_basic
=== RUN   TestAccAzureRMEventGridTopic_basicWithTags
=== PAUSE TestAccAzureRMEventGridTopic_basicWithTags
=== CONT  TestAccAzureRMEventGridTopic_basic
=== CONT  TestAccAzureRMEventGridTopic_basicWithTags
--- PASS: TestAccAzureRMEventGridTopic_basic (153.90s)
--- PASS: TestAccAzureRMEventGridTopic_basicWithTags (196.36s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests     196.684s

@ghost ghost removed the waiting-response label Jan 14, 2020
@jackbatzner jackbatzner requested a review from katbyte January 14, 2020 18:07
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Brunhil

Thanks for pushing those changes - taking a look through besides one minor comment (which I hope you don't mind but I'm going to push a commit to fix) this now LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review January 15, 2020 07:24

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff added this to the v1.41.0 milestone Jan 15, 2020
@tombuildsstuff tombuildsstuff merged commit b85bb0f into hashicorp:master Jan 15, 2020
tombuildsstuff added a commit that referenced this pull request Jan 15, 2020
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the event-grid-datasource branch March 14, 2020 14:49
@ghost
Copy link

ghost commented Mar 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants