-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data source: 'azurerm_eventgrid_topic' #5367
New data source: 'azurerm_eventgrid_topic' #5367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Brunhil,
Thanks for the data source, in additional to one minor comment it appears the tests are failing:
Test Failed
------- Stdout: -------
=== RUN TestAccDataSourceAzureRMEventGridTopic_basic
=== PAUSE TestAccDataSourceAzureRMEventGridTopic_basic
=== CONT TestAccDataSourceAzureRMEventGridTopic_basic
--- FAIL: TestAccDataSourceAzureRMEventGridTopic_basic (0.27s)
testing.go:569: Step 0 error: config is invalid: Reference to undeclared resource: A managed resource "azurerm_event_grid_topic" "test" has not been declared in the root module.
azurerm/internal/services/eventgrid/data_source_eventgrid_topic.go
Outdated
Show resolved
Hide resolved
- Fix ordering of properties - Validate' name' property - Fix acceptance test
Fixes pushed and verified tests run! Event Grid Topic Data Source
Event Grid Topic Resource
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Brunhil
Thanks for pushing those changes - taking a look through besides one minor comment (which I hope you don't mind but I'm going to push a commit to fix) this now LGTM 👍
Thanks!
dismissing since changes have been pushed
This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.41.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Expose the 'azurerm_eventgrid_topic' resource as a data source