-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_batch_pool - support for the metadata
property (#4611)
#5309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr @sergiupantiru! this is looking great. There are only a few minor comments i've left in line that need to be addressed before merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sergiupantiru
Thanks for pushing those changes - I've taken a look through and left a few minor comments inline but this otherwise LGTM 👍
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @sergiupantiru, this LGTM now 🚀
Nice! Thanks @katbyte and @tombuildsstuff for the input ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sergiupantiru
Thanks for pushing those changes - I've left one minor comment inline regarding a potential crash if the Azure API returns a malformed response, but this otherwise LGTM 👍
Thanks!
Co-Authored-By: Tom Harvey <[email protected]>
@sergiupantiru thanks for pushing those changes - I hope you don't mind but I've pushed a commit to fix the linting so that we can get this merged 👍 |
No problem. Saw the extra line did not thing it would be an issue :) |
metadata
property (#4611)
This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.41.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Trying to add enhancement #4611
Fixes #4611