New Resource: azurerm_api_management_identity_provider_google

[aqche]

Partially addresses: #5044

Adds the azurerm_api_management_identity_provider_google resource.

--- PASS: TestAccAzureRMApiManagementIdentityProviderGoogle_basic (1801.15s)
--- PASS: TestAccAzureRMApiManagementIdentityProviderGoogle_update (1862.55s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/apimanagement/tests 1862.64

[katbyte]

Thanks for this new resource @aqche, this LGTM aside from two minor comments i've left inline.

[katbyte]

Could we change this to match what google calls this:

Suggested change

	"client_secret": {
	"api_key": {

[aqche]

I believe both Azure and Google actually refer to the value as client secret. I'll update the documentation to reflect this.

[katbyte]

If you look at the SDK docs (and presumably the API) it states:

// ClientSecret - Client secret of the Application in external Identity Provider, used to authenticate login request. For example, it is App Secret for Facebook login, API Key for Google login, Public Key for Microsoft.

Is this inaccurate and client secret is what you would look for on the google side?

[aqche]

Yep, it is called client secret as well on the Google side.

[katbyte]

perfect, thanks for that!

[katbyte]

Is there a validation we could do on this value?

[aqche]

@katbyte thanks for the review! made updates to the PR based on your comments. let me know what you think

[katbyte]

Thanks @aqche! LGTM now 👍

[ghost]

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!