Fix product api not reassigned on manual delete #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a bug that reflects Azure apimanagement API behaviour changes from 2018-01-01 to 2019-01-01
|
I made a PR #5096 for upgrading. Care to have a look? I think it needs review. I've done some basic testing myself, but it would be nice to gain some confidence from someone else testing it. |
tombuildsstuff
approved these changes
Dec 16, 2019
|
Tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Dec 16, 2019
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5002
Due to behaviour changes in Azure apimanagement API, HTTP 404 response code was not considered an error in version 2018-01-01 and is now considered an error in 2019-01-01. To fix the behavior in the currently used API version, we need to also check for ResponseWasNotFound, when the CheckEntityExists produces no error.