-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_sql_database
- support for the extended_auditing_policy
property
#5049
Conversation
Hi @tombuildsstuff , sorry to block you, because I think that the closed PR won't be reviewed any more. I have replied comments in #4982. Please review. |
hi @tombuildsstuff , any problem? |
@tombuildsstuff @katbyte I've removed some less useful fields. Please continue reviewing. |
block blob_extended_auditing_policy
in resource: resource_arm_sql_database
blob_extended_auditing_policy
in resource: resource_arm_sql_database
@tombuildsstuff I have made some updates. Please continue reviewing it and #5036 |
blob_extended_auditing_policy
in resource: resource_arm_sql_database
extended_auditing_policy
in resource: resource_arm_sql_database
Hi @katbyte , auditing block in resource_arm_sql_database has been updated according to changes in PR resource_arm_sql_server. Please help to review. |
extended_auditing_policy
in resource: resource_arm_sql_database
azurerm_sql_database
- support for the extended_auditing_policy
property
azurerm_sql_database
- support for the extended_auditing_policy
propertyazurerm_sql_database
- support for the extended_auditing_policy
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! couple minor comments on the tests and this should be ready to merge!
azurerm/internal/services/sql/tests/resource_arm_sql_database_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions @yupwei68, LGTM 👍
This has been released in version 2.2.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.2.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Similar to #5036
continuation of #4982