Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_iothub_route #4923

Merged
merged 2 commits into from
Nov 21, 2019
Merged

New Resource: azurerm_iothub_route #4923

merged 2 commits into from
Nov 21, 2019

Conversation

mbfrahry
Copy link
Member

This is a continuation of #3677 . That extracts endpoints out of the iothub resource.

--- PASS: TestAccAzureRMIotHubRoute_basic (471.91s)
--- PASS: TestAccAzureRMIotHubRoute_update (590.35s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Remove deprecation tag

Add nil checks

Add comment to doc around endpoints

Lint empty lines
@mbfrahry mbfrahry merged commit b7371f9 into master Nov 21, 2019
@mbfrahry mbfrahry deleted the f-iothub-route branch November 21, 2019 23:04
mbfrahry added a commit that referenced this pull request Nov 21, 2019
@tombuildsstuff tombuildsstuff modified the milestones: v1.38.0, v1.37.0 Nov 22, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants