Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_subscription - support for the forward_dead_lettered_messages_to property #4789

Merged
merged 3 commits into from
Nov 1, 2019
Merged

azurerm_servicebus_subscription - support for the forward_dead_lettered_messages_to property #4789

merged 3 commits into from
Nov 1, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Nov 1, 2019

Adds the forward_dead_lettered_messages_to argument to azurerm_servicebus_subscription to address #4542

@katbyte katbyte changed the title Add support for ForwardDeadLetteredMessagesTo for ServiceBus Subscription azurerm_servicebus_subscription - support fo the forward_dead_lettered_messages_to property Nov 1, 2019
@katbyte katbyte changed the title azurerm_servicebus_subscription - support fo the forward_dead_lettered_messages_to property azurerm_servicebus_subscription - support for the forward_dead_lettered_messages_to property Nov 1, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @aqche! LGTM 👍

@katbyte katbyte added this to the v1.37.0 milestone Nov 1, 2019
@katbyte katbyte merged commit b8aee9f into hashicorp:master Nov 1, 2019
katbyte added a commit that referenced this pull request Nov 1, 2019
@aqche
Copy link
Contributor Author

aqche commented Nov 2, 2019

@katbyte thanks for the review! :)

@aqche aqche deleted the add_forward_dead_lettered_messages_to_azurerm_servicebus_subscription branch November 2, 2019 03:31
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants