Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - prevent possible nil crashes when flattening the service_principal_profile property. #4697

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

sudomateo
Copy link
Contributor

@sudomateo sudomateo commented Oct 23, 2019

This should fix the following panic.

panic: interface conversion: interface {} is nil, not map[string]interface {}

Should fix #4519.

@ghost ghost added the size/XS label Oct 23, 2019
@katbyte katbyte changed the title Adding nil check when length greater than zero azurerm_kubernetes_cluster - prevent possible nil crashes when flattening the service_principal_profile property. Oct 23, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 23, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.35 version crash, AKS SP problem
2 participants