Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application_collection): updated api ver, added mssql protocol #4596

Merged
merged 5 commits into from
Nov 17, 2019
Merged

feat(application_collection): updated api ver, added mssql protocol #4596

merged 5 commits into from
Nov 17, 2019

Conversation

BrendanThompson
Copy link
Contributor

  • Updated the API version to 2019-07-01 to allow for use of the Mssql const
  • Added Mssql type into Protocol validation

RELATES: #4595

@ghost ghost added the size/XS label Oct 11, 2019
@tombuildsstuff tombuildsstuff self-assigned this Oct 31, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @BrendanThompson

Thanks for this PR - apologies for the delayed review here!

Taking a look through this is looking good to me; since there's a merge conflict here I hope you don't mind but I'm going to rebase this then push a commit to fix the outstanding comments - but this otherwise LGTM 👍

Thanks!

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Nov 17, 2019
@ghost ghost added size/XXL and removed size/XS labels Nov 17, 2019
@tombuildsstuff tombuildsstuff merged commit d6c7484 into hashicorp:master Nov 17, 2019
tombuildsstuff added a commit that referenced this pull request Nov 17, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants