-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(application_collection): updated api ver, added mssql protocol #4596
feat(application_collection): updated api ver, added mssql protocol #4596
Conversation
- Updated the API version to `2019-07-01` to allow for use of the Mssql const - Added Mssql type into Protocol validation RELATES: #4595
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @BrendanThompson
Thanks for this PR - apologies for the delayed review here!
Taking a look through this is looking good to me; since there's a merge conflict here I hope you don't mind but I'm going to rebase this then push a commit to fix the outstanding comments - but this otherwise LGTM 👍
Thanks!
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
2019-07-01
to allow for use of the Mssql constRELATES: #4595