-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_api_management_api
- the version
and version_set_id
properties can now be set
#4592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @kraihn
Thanks for this PR :)
Taking a look through this is off to a good start - if we can add some documentation/tests for this this should otherwise be good to merge 👍
Thanks!
version
and version_set_id
for azurerm_api_management_api
version
and version_set_id
for azurerm_api_management_api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @kraihn
Thanks for pushing those changes - apologies for the delayed review here.
This is looking pretty good, I've taken a look through and left some comments inline.
Running the tests for this:
The test TestAccAzureRMApiManagementApi_version
fails with:
Error: `version_set_id` is required when `version` is set
Because whilst this field is set in the test, this field is interpolated (and due to a bug in CustomizeDiff, interpolated fields return an empty value, which fails this validation function) - as such if we can remove the CustomizeDiff
func then this test should pass
Thanks!
Would be great to get this added, currently it is impossible to create versioned APIs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisins @kraihn! LGTM now 👍
version
and version_set_id
for azurerm_api_management_api
azurerm_api_management_api
- the version
and version_set_id
properties can now be set
This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Should fix #4297
This is my first Terraform provider pull request and step into programming in Go. What am I missing? Is there anything I need to be aware of in terms of a list of items to check or validate? The footprint of the arguments I'm interested in appears to be small.