Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute: upgrading the API Version to 2019-07-01 #4331

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR upgrades the version of the Compute API to 2019-07-01, which is required for building support for the new Virtual Machine & Virtual Machine Scale Set resources for 2.0

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Sep 16, 2019
@ghost ghost added the size/XXL label Sep 16, 2019
@tombuildsstuff tombuildsstuff requested a review from a team September 16, 2019 08:54
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Ran the test suite and the Acceptance Tests look ok 👍

@tombuildsstuff tombuildsstuff merged commit d2a4f22 into master Sep 18, 2019
@tombuildsstuff tombuildsstuff deleted the f/compute-api-upgrade branch September 18, 2019 11:31
tombuildsstuff added a commit that referenced this pull request Sep 18, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants