Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariadb storage autogrow #4302

Merged
merged 4 commits into from
Sep 12, 2019

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Sep 12, 2019

Requested here: #4295

This is the MariaDB part only. MySQL to follow

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @r0bnet

Thanks for this PR - taking a look through if we can update the parameter name to match the equivalent PostgreSQL resource then this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_mariadb_server.go Show resolved Hide resolved
azurerm/resource_arm_mariadb_server.go Outdated Show resolved Hide resolved
azurerm/resource_arm_mariadb_server_test.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@r0bnet r0bnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed all your comments. Makes sense to me :)

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing those changes @r0bnet, this now LGTM :)

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-09-12 at 13 14 47

@tombuildsstuff tombuildsstuff merged commit b7975eb into hashicorp:master Sep 12, 2019
tombuildsstuff added a commit that referenced this pull request Sep 12, 2019
@r0bnet r0bnet deleted the mariadb-storage-autogrow branch September 12, 2019 12:38
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants