Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_bot_channels_registration #4245

Merged
merged 5 commits into from
Sep 5, 2019
Merged

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Sep 4, 2019

No description provided.

@mbfrahry
Copy link
Member Author

mbfrahry commented Sep 5, 2019

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments this LGTM 👍

azurerm/resource_arm_bot_channels_registration.go Outdated Show resolved Hide resolved
azurerm/resource_arm_bot_channels_registration.go Outdated Show resolved Hide resolved
azurerm/resource_arm_bot_channels_registration.go Outdated Show resolved Hide resolved
website/docs/r/bot_channels_registration.markdown Outdated Show resolved Hide resolved
@mbfrahry mbfrahry merged commit e76b8c1 into master Sep 5, 2019
@mbfrahry mbfrahry deleted the f-bot-channel branch September 5, 2019 15:45
@katbyte katbyte added this to the v1.34.0 milestone Oct 30, 2019
@ghost
Copy link

ghost commented Oct 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants