Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_sql_container doesnt support updates but suggests update will run #4162

Closed
MarkDordoy opened this issue Aug 27, 2019 · 3 comments

Comments

@MarkDordoy
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.6
provider.azurerm v1.33.0

Affected Resource(s)

  • azurerm_cosmosdb_sql_container

Terraform Configuration Files

# Original setup

resource "azurerm_cosmosdb_sql_container" "termsets_termsettemplates" {
    name                = "termsettemplates"
    resource_group_name = data.azurerm_resource_group.resource_group.name
    account_name        = "mydbname
    database_name       = termsettemplates
    partition_key_path  = "/id"
    unique_key {
        paths = ["/Name"]
    }
}

# Error Occurred when changing to this - Added unique key path

resource "azurerm_cosmosdb_sql_container" "termsets_termsettemplates" {
    name                = "termsettemplates"
    resource_group_name = data.azurerm_resource_group.resource_group.name
    account_name        = "mydbname
    database_name       = termsettemplates
    partition_key_path  = "/id"
    unique_key {
        paths = ["/Name", "/Version"]
    }
}

Debug Output

Terraform will perform the following actions:

  # azurerm_cosmosdb_sql_container.termsets_termsettemplates will be updated in-place
  ~ resource "azurerm_cosmosdb_sql_container" "termsets_termsettemplates" {
        account_name        = "########"
        database_name       = "termsets"
        id                  = "/subscriptions/##########/resourceGroups/#####/providers/Microsoft.DocumentDB/databaseAccounts/#####/apis/sql/databases/termsets/containers/termsettemplates"
        name                = "termsettemplates"
        partition_key_path  = "/id"
        resource_group_name = "#######"

      + unique_key {
          + paths = [
              + "/Name",
              + "/Version",
            ]
        }
      - unique_key {
          - paths = [
              - "/Name",
            ] -> null
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

azurerm_cosmosdb_sql_container.termsets_termsettemplates: Modifying... [id=/subscriptions/####/resourceGroups/####/providers/Microsoft.DocumentDB/databaseAccounts/####/apis/sql/databases/termsets/containers/termsettemplates]

Error: doesn't support update

  on cosmosdb.tf line 175, in resource "azurerm_cosmosdb_sql_container" "termsets_termsettemplates":
 175: resource "azurerm_cosmosdb_sql_container" "termsets_termsettemplates" {

Expected Behavior

I would expect terraform to suggest this would be a destroy and recreate rather than an update

Actual Behavior

Says it will be and update then fails as this is not possible with this resource

Steps to Reproduce

Create a container then try and update the unique key

@MarkDordoy
Copy link
Contributor Author

Will be fixed in release 1.34.0
Thanks @katbyte

@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants