Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: dynamically requesting an authorizer for storage #4099

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR changes the Authorizer used for Storage to ensure it requests a token that's valid for storage.azure.com - used to access the Storage API's.

This requires a little more testing prior to merging - but in testing appears to resolve this both in CloudShell and when authenticating using the Azure CLI

Fixes #3997

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit dd4ffec into master Aug 16, 2019
@tombuildsstuff tombuildsstuff deleted the b/storage-auth-bug branch August 16, 2019 15:58
tombuildsstuff added a commit that referenced this pull request Aug 16, 2019
@ghost
Copy link

ghost commented Aug 22, 2019

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading queue properties for AzureRM Storage Account
2 participants