Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve full URL for event grid subscription webhooks #3630

Merged

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Jun 10, 2019

- Read the full URL of the event grid subscription webhook, which will
include any query params and authentication codes. Without this, using
the webhook with e.g. a function app will return a diff with an empty
URL during the read
@ghost ghost added the size/XS label Jun 10, 2019
@phekmat
Copy link
Contributor Author

phekmat commented Jun 10, 2019

Didn't see any existing associated tests that used the webhook; they're a bit awkward to automate since the event grid won't add the subscription without validating the endpoint first. I'm not sure if I'll have time to add tests to this PR, so feel free to run with it.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @phekmat

@katbyte katbyte merged commit 3bf4a5f into hashicorp:master Jun 13, 2019
katbyte added a commit that referenced this pull request Jun 13, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_eventgrid_event_subscription returns a diff for webhooks
3 participants