Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_arm_application_gateway: add disabled_rule_group to waf_configuration #3394

Merged
merged 2 commits into from
May 9, 2019
Merged

resource_arm_application_gateway: add disabled_rule_group to waf_configuration #3394

merged 2 commits into from
May 9, 2019

Conversation

bs-matil
Copy link
Contributor

@bs-matil bs-matil commented May 7, 2019

This PR add a disabled_rule_group block to the waf_configuration block. This enables a user to disable waf rules

@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from 2dc4db8 to 0281b66 Compare May 7, 2019 13:25
@bs-matil bs-matil mentioned this pull request May 7, 2019
Closed
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from 0281b66 to 72e72ee Compare May 7, 2019 13:34
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from 72e72ee to 3e45a56 Compare May 7, 2019 14:00
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch 2 times, most recently from 8e2522b to f2f7344 Compare May 7, 2019 14:13
@bs-matil bs-matil changed the title resource_arm_application_gateway: add advanced waf_configuration with… resource_arm_application_gateway: add disabled_rule_group to waf_configuration May 7, 2019
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from f2f7344 to 5443821 Compare May 7, 2019 14:19
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from 5443821 to 3cc0aa4 Compare May 7, 2019 14:33
@mbfrahry mbfrahry self-assigned this May 7, 2019
mbfrahry
mbfrahry requested changes May 7, 2019
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bs-matil. Thanks for submitting this PR. Things are generally good but we just want to make sure these features are consistent with how everything else is done in this resource with additional expand and flatten methods, a little bit more validation, and an additional test check. Other than that, things are great!

azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway_test.go Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
website/docs/r/application_gateway.html.markdown Outdated Show resolved Hide resolved
website/docs/r/application_gateway.html.markdown Outdated Show resolved Hide resolved
azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
@ghost ghost added size/XL and removed size/L labels May 8, 2019
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from 68946c9 to c702fd2 Compare May 8, 2019 07:50
@bs-matil
resource_arm_application_gateway: add review fixes -> flatten, expand…
728ad82 
… methods for group_rules, doc fixes, additional test steps
@bs-matil bs-matil force-pushed the upstream/application-gateway-advanced-waf-configuration-disables-rules-groups branch from c702fd2 to 728ad82 Compare May 8, 2019 08:05
@bs-matil
Copy link
Contributor Author

bs-matil commented May 8, 2019

@mbfrahry I submitted fixes for "all" issues. Please review again.

@mbfrahry mbfrahry merged commit d4ac51d into hashicorp:master May 9, 2019
@tombuildsstuff tombuildsstuff mentioned this pull request May 14, 2019
Closed
@t0klian
Copy link
Contributor

t0klian commented May 19, 2019

It is not possible to disable OWASP3,0 rule 200004 from General rule group with implemented solution

@ghost
Copy link

ghost commented Jun 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timja timja timja left review comments

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees

@mbfrahry mbfrahry

Labels
documentation enhancement service/application-gateway size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bs-matil @t0klian @mbfrahry @timja