Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iothub IP filters #3173

Merged
merged 8 commits into from
Apr 8, 2019
Merged

Conversation

Lucretius
Copy link
Contributor

Resolves #1699 by adding the ability to configure IP Filter rules for the iothub resource. Updated the documentation accordingly and added a test.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Lucretius

Thanks for this PR :)

Taking a through this mostly LGTM - if we can fix up the minor comments then this should be good to merge 👍

Thanks!

azurerm/resource_arm_iothub.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub.go Outdated Show resolved Hide resolved
@Lucretius
Copy link
Contributor Author

I've added the desired changes. Thanks for the feedback!

@ghost ghost removed the waiting-response label Apr 4, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revisions @Lucretius, Aside from one minor comment this LGTM 👍

azurerm/resource_arm_iothub.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff dismissed their stale review April 6, 2019 08:16

dismissing since changes have been pushed

@tombuildsstuff tombuildsstuff added this to the v1.25.0 milestone Apr 6, 2019
@Lucretius
Copy link
Contributor Author

@tombuildsstuff not a problem, thanks for doing that!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-04-08 at 04 50 42

@tombuildsstuff tombuildsstuff merged commit df59e0b into hashicorp:master Apr 8, 2019
tombuildsstuff added a commit that referenced this pull request Apr 8, 2019
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IoT Hub IP Filter Rules
3 participants