Public ip prefix

[steve-hawkins]

This should fulfil Issue #2239

(fixes #2239)

[katbyte]

Hi @steve-hawkins,

Thank you for the new resource! aside from a few minor comments i've left inline this is looking pretty good. Once those are addressed and the tests pass i think this will be good to merge 🙂

[steve-hawkins]

@katbyte thanks for your review and comments

hopefully covered them all off now, let me know if all looks good

[steve-hawkins]

@katbyte let me know if there is anything else needed to get this PR merged in for 1.24

[katbyte]

Hi @steve-hawkins,

It looks like the tests are failing:

------- Stdout: -------
=== RUN   TestAccAzureRMPublicIpStatic_basicOld
=== PAUSE TestAccAzureRMPublicIpStatic_basicOld
=== CONT  TestAccAzureRMPublicIpStatic_basicOld
--- FAIL: TestAccAzureRMPublicIpStatic_basicOld (61.22s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* azurerm_public_ip.test: 1 error occurred:
        	* azurerm_public_ip.test: Error Creating/Updating Public IP "acctestpublicip-190409035251288931" (Resource Group "acctestRG-190409035251288931"): network.PublicIPAddressesClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="LinkedInvalidPropertyId" Message="Property id '' at path 'properties.publicIPPrefix.id' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'."
        
        
        
        
FAIL

[steve-hawkins]

Hi @katbyte apologies for the delay

Those tests should pass now

[katbyte]

Thanks for fixing that @steve-hawkins, LGTM now 🚀

[ghost]

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!