Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: azurerm_servicebus_namespace #2841

Merged
merged 2 commits into from
Feb 7, 2019
Merged

New Data Source: azurerm_servicebus_namespace #2841

merged 2 commits into from
Feb 7, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Tests pass:

$ acctests azurerm TestAccDataSourceAzureRMServiceBusNamespace_
=== RUN   TestAccDataSourceAzureRMServiceBusNamespace_basic
=== PAUSE TestAccDataSourceAzureRMServiceBusNamespace_basic
=== RUN   TestAccDataSourceAzureRMServiceBusNamespace_premium
=== PAUSE TestAccDataSourceAzureRMServiceBusNamespace_premium
=== CONT  TestAccDataSourceAzureRMServiceBusNamespace_basic
--- PASS: TestAccDataSourceAzureRMServiceBusNamespace_basic (422.34s)
=== CONT  TestAccDataSourceAzureRMServiceBusNamespace_premium
--- PASS: TestAccDataSourceAzureRMServiceBusNamespace_premium (517.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	940.106s

Fixes #2833

@tombuildsstuff
New Data Source: azurerm_servicebus_namespace
0cb50db 
Tests pass:

```
$ acctests azurerm TestAccDataSourceAzureRMServiceBusNamespace_
=== RUN   TestAccDataSourceAzureRMServiceBusNamespace_basic
=== PAUSE TestAccDataSourceAzureRMServiceBusNamespace_basic
=== RUN   TestAccDataSourceAzureRMServiceBusNamespace_premium
=== PAUSE TestAccDataSourceAzureRMServiceBusNamespace_premium
=== CONT  TestAccDataSourceAzureRMServiceBusNamespace_basic
--- PASS: TestAccDataSourceAzureRMServiceBusNamespace_basic (422.34s)
=== CONT  TestAccDataSourceAzureRMServiceBusNamespace_premium
--- PASS: TestAccDataSourceAzureRMServiceBusNamespace_premium (517.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	940.106s
```
katbyte
katbyte approved these changes Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the missing documentation and one question LGTM 👍

website/docs/d/servicebus_namespace.html.markdown Outdated Show resolved Hide resolved
azurerm/data_source_servicebus_namespace.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the 1.22.0 milestone Feb 7, 2019
@tombuildsstuff tombuildsstuff merged commit 41bafb3 into master Feb 7, 2019
@tombuildsstuff tombuildsstuff deleted the f/data-source-servicbus-namespace branch February 7, 2019 10:48
tombuildsstuff added a commit that referenced this pull request Feb 7, 2019
@tombuildsstuff
Updating to include #2841
86f6a1d
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/service-bus size/L
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging this pull request may close these issues.

Service bus data source
2 participants
@tombuildsstuff @katbyte