Introduce Additional Oracle Data Sources. #27698

eelhomsi · 2024-10-18T13:18:56Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Introduce additional Oracle Data Sources
Most relevant changes in:
internal/services/oracle/

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

FEATURES - Introduced: AdbsCharSetsDataSource, AdbsNCharSetsDataSource, DBNodesDataSource, DbSystemShapesDataSource, and GiVersionsDataSource.

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

…down Co-authored-by: kt <[email protected]>

… into introduce-exa-data-and-resource

…ce_test.go

…e-exa-data-and-resource

…points

internal/services/oracle/autonomous_database_nchar_set_data_source_test.go

internal/services/oracle/db_system_shapes_data_source.go

internal/services/oracle/gi_versions_data_source.go

stephybun · 2024-10-24T10:05:25Z

website/docs/d/oracle_adbs_character_sets.html.markdown

+
+The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/language/resources/syntax#operation-timeouts) for certain actions:
+
+* `read` - (Defaults to 5 minutes) Used when retrieving the Oracle.


Oracle what?

stephybun · 2024-10-24T10:05:33Z

website/docs/d/oracle_adbs_national_character_sets.html.markdown

+
+The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/language/resources/syntax#operation-timeouts) for certain actions:
+
+* `read` - (Defaults to 5 minutes) Used when retrieving the Oracle.


Oracle what?

stephybun · 2024-10-24T10:06:15Z

website/docs/d/oracle_db_nodes.html.markdown

+  resource_group_name   = "existing"
+  cloud_vm_cluster_name = "existing"


This hasn't been updated

stephybun · 2024-10-24T10:06:24Z

website/docs/d/oracle_db_nodes.html.markdown

+* `cloud_vm_cluster_name` - (Required) The name of the Cloud VM cluster.
+
+* `resource_group_name` - (Required) The name of the Resource Group the Cloud VM Cluster.


Also hasn't been updated

Co-authored-by: stephybun <[email protected]>

…urce_test.go Co-authored-by: stephybun <[email protected]>

eelhomsi · 2024-10-24T11:51:19Z

New test evidence here:

…points

stephybun

Thanks @eelhomsi LGTM 🌲

github-actions · 2024-11-25T02:17:11Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

eelhomsi and others added 30 commits August 9, 2024 21:44

* Add Exadata Infrastructure files.

90eb21b

Merge branch 'main' into introduce-exa-data-and-resource

9482eba

* Add docs for db_server data source.

22a45cc

* Update.

ac87fb3

* Implement ADBS resource and data source.

4ae5b29

* Implement ADBS resource and data source.

f0f64f8

* Format.

d26aada

* Improve tests.

24cc8a8

* Improvements.

d1e4479

* Add additional endpoint data sources and tests.

3fdf21a

* Move to bottom.

16a5e92

* Add validators.

61e90b7

* Format blocks.

6f35ff7

* Add ADBS scaling.

4ff5f25

* Remove month validator.

504bfc2

* Address comments.

19bc88c

Update website/docs/r/oracledatabase_exadata_infrastructure.html.mark…

b3e4f33

…down Co-authored-by: kt <[email protected]>

Update website/docs/r/oracledatabase_exadata_infrastructure.html.mark…

76a1f16

…down Co-authored-by: kt <[email protected]>

Update website/docs/r/oracledatabase_exadata_infrastructure.html.mark…

4652730

…down Co-authored-by: kt <[email protected]>

* Address comments.

4ab3c70

Merge remote-tracking branch 'origin/introduce-exa-data-and-resource'…

659816a

… into introduce-exa-data-and-resource

Update internal/services/oracledatabase/exadata_infrastructure_resour…

2253a16

…ce_test.go

Update internal/services/oracledatabase/exadata_infrastructure_resour…

936cd8c

…ce_test.go

* Fix website linter issues.

153ec94

Merge remote-tracking branch 'refs/remotes/origin/main' into introduc…

aea4588

…e-exa-data-and-resource

* Merge from main.

5f7eb7c

* Update test.

a46e0d7

* Remove fields not supported in ODB@A UI.

7442f44

Merge remote-tracking branch 'refs/remotes/origin/main' into info-end…

5c05e60

…points

* Merge changes.

35b57f7

Merge remote-tracking branch 'origin/info-endpoints' into info-endpoints

57b6ee5

github-actions bot added the waiting-response label Oct 24, 2024

* Format.

f2d17a3

github-actions bot added waiting-response and removed waiting-response labels Oct 24, 2024

* Update tests.

afa6396

github-actions bot added waiting-response and removed waiting-response labels Oct 24, 2024

* Update tests.

bad4522

github-actions bot removed the waiting-response label Oct 24, 2024

stephybun requested changes Oct 24, 2024

View reviewed changes

github-actions bot added the waiting-response label Oct 24, 2024

eelhomsi and others added 3 commits October 24, 2024 11:10

Update internal/services/oracle/gi_versions_data_source.go

ee96f81

Co-authored-by: stephybun <[email protected]>

Update internal/services/oracle/db_system_shapes_data_source.go

d6d9441

Co-authored-by: stephybun <[email protected]>

Update internal/services/oracle/autonomous_database_nchar_set_data_so…

1606c94

…urce_test.go Co-authored-by: stephybun <[email protected]>

github-actions bot removed the waiting-response label Oct 24, 2024

* Address final comments.

b5f207e

github-actions bot added the waiting-response label Oct 24, 2024

* Address final comments.

5869e7a

github-actions bot removed the waiting-response label Oct 24, 2024

* Fix test.

74dd612

eelhomsi added 2 commits October 24, 2024 13:44

Merge remote-tracking branch 'refs/remotes/origin/main' into info-end…

636d371

…points

* Update.

4a19fe5

stephybun approved these changes Oct 24, 2024

View reviewed changes

stephybun merged commit 36e7304 into hashicorp:main Oct 24, 2024
33 checks passed

github-actions bot added this to the v4.7.0 milestone Oct 24, 2024

stephybun added a commit that referenced this pull request Oct 24, 2024

Update for #27698

69ac1c4

github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Additional Oracle Data Sources. #27698

Introduce Additional Oracle Data Sources. #27698

eelhomsi commented Oct 18, 2024 •

edited

Loading

stephybun Oct 24, 2024

eelhomsi Oct 24, 2024

stephybun Oct 24, 2024

eelhomsi Oct 24, 2024

stephybun Oct 24, 2024

eelhomsi Oct 24, 2024

stephybun Oct 24, 2024

eelhomsi Oct 24, 2024

eelhomsi commented Oct 24, 2024

stephybun left a comment

github-actions bot commented Nov 25, 2024


		The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/language/resources/syntax#operation-timeouts) for certain actions:

		* `read` - (Defaults to 5 minutes) Used when retrieving the Oracle.

		resource_group_name = "existing"
		cloud_vm_cluster_name = "existing"

		* `cloud_vm_cluster_name` - (Required) The name of the Cloud VM cluster.

		* `resource_group_name` - (Required) The name of the Resource Group the Cloud VM Cluster.

Introduce Additional Oracle Data Sources. #27698

Introduce Additional Oracle Data Sources. #27698

Conversation

eelhomsi commented Oct 18, 2024 • edited Loading

Community Note

Description

PR Checklist

Testing

Change Log

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eelhomsi commented Oct 24, 2024

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 25, 2024

eelhomsi commented Oct 18, 2024 •

edited

Loading