New Resource: `azurerm_eventgrid_namespace` #27682

catriona-m · 2024-10-17T14:49:53Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Adding azurerm_eventgrid_namespace as a new resource.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Resource: azurerm_eventgrid_namespace [New Resource: azurerm_eventgrid_namespace #27682]

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Related Issue(s)

Fixes #24079

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

stephybun

Thanks @catriona-m, could you take a look at the review comments left in-line?

stephybun · 2024-10-29T08:59:47Z

internal/services/eventgrid/eventgrid_namespace_resource.go

+	PublicNetworkAccess      string                                     `tfschema:"public_network_access"`
+	Sku                      string                                     `tfschema:"sku"`
+	TopicSpacesConfiguration []TopicSpacesConfigurationModel            `tfschema:"topic_spaces_configuration"`
+	ZoneRedundant            bool                                       `tfschema:"zone_redundant"`


This field was deprecated and removed in 4.0 not too long ago for the service bus and event hub namespace resources. We may want to check with MSFT whether this is also the case for event grid before exposing this.

Thanks @stephybun - I tested this and confirmed the api handles setting this based on location so it can be removed here 👍

internal/services/eventgrid/eventgrid_namespace_resource.go

stephybun · 2024-10-29T09:01:05Z

internal/services/eventgrid/eventgrid_namespace_resource.go

+		"inbound_ip_rule": {
+			Type:       pluginsdk.TypeList,
+			Optional:   true,
+			ConfigMode: pluginsdk.SchemaConfigModeAttr,


This isn't Computed so I don't think we need to be setting this on the block

Suggested change

ConfigMode: pluginsdk.SchemaConfigModeAttr,

internal/services/eventgrid/eventgrid_namespace_resource.go

stephybun · 2024-10-29T09:02:47Z

internal/services/eventgrid/eventgrid_namespace_resource.go

+								"key": {
+									Type:     pluginsdk.TypeString,
+									Required: true,
+								},
+
+								"value": {
+									Type:     pluginsdk.TypeString,
+									Required: true,
+								},


Validation here?

stephybun · 2024-10-29T09:09:21Z

internal/services/eventgrid/eventgrid_namespace_resource_test.go

+
+

Suggested change

stephybun · 2024-10-29T09:10:13Z

internal/services/eventgrid/eventgrid_namespace_resource_test.go

+
+	data.ResourceTest(t, r, []acceptance.TestStep{
+		{
+			Config: r.basicWithTags(data),


Tags can be updated but it looks like we don't cover this in the tests

stephybun · 2024-10-29T09:10:59Z

website/docs/r/eventgrid_namespace.html.markdown

+
+* `location` - (Required) Specifies the supported Azure location where the resource should exist. Changing this forces a new resource to be created.
+
+* `capacity` - (Optional)  (Optional) Specifies the Capacity / Throughput Units for an Eventgrid Namespace. Valid values can be between `1` and `40`.


Suggested change

* `capacity` - (Optional) (Optional) Specifies the Capacity / Throughput Units for an Eventgrid Namespace. Valid values can be between `1` and `40`.

* `capacity` - (Optional) Specifies the Capacity / Throughput Units for an Eventgrid Namespace. Valid values can be between `1` and `40`.

stephybun · 2024-10-29T09:12:14Z

website/docs/r/eventgrid_namespace.html.markdown

+
+* `alternative_authentication_name_source` - (Optional) Specifies a list of alternative sources for the client authentication name from the client certificate. Possible values are `ClientCertificateDns`, `ClientCertificateEmail`, `ClientCertificateIp`, `ClientCertificateSubject` and `ClientCertificateUri`.
+
+* `maximum_client_sessions_per_authentication_name` - (Optional) Specifies the maximum number of client sessions epr authentication name. Valid values can be between `1` and `100`.


Suggested change

* `maximum_client_sessions_per_authentication_name` - (Optional) Specifies the maximum number of client sessions epr authentication name. Valid values can be between `1` and `100`.

* `maximum_client_sessions_per_authentication_name` - (Optional) Specifies the maximum number of client sessions per authentication name. Valid values can be between `1` and `100`.

stephybun · 2024-10-29T09:12:39Z

website/docs/r/eventgrid_namespace.html.markdown

+
+* `maximum_session_expiry_in_hours` - (Optional) Specifies the maximum session expiry interval allowed for all MQTT clients connecting to the Event Grid namespace. Valid values can be between `1` and `8`.
+
+* `route_topic_id` - (Optional) Specifies the Event Grid topic resource id to route messages to.


Suggested change

* `route_topic_id` - (Optional) Specifies the Event Grid topic resource id to route messages to.

* `route_topic_id` - (Optional) Specifies the Event Grid topic resource ID to route messages to.

sbugalski · 2024-11-04T11:15:23Z

Many thanks for the work.

Any update on this please?

stephybun

Thanks @catriona-m. A few more minor comments, but other than that this LGTM provided the tests are passing!

stephybun · 2024-11-19T07:46:01Z

internal/services/eventgrid/eventgrid_namespace_resource.go

+}
+
+func flattenInboundIPRules(ipRules *[]namespaces.InboundIPRule) []InboundIpRuleModel {
+	var output []InboundIpRuleModel


Forgot to flag this in my previous review, there is a difference between declaring a slice like this and like
output := make([]InboundIpRuleModel, 0)

Which is that the declaration var output []InboundIpRuleModel evaluates to nil if nothing has been appended to it, whereas initialising it with make will result in an empty slice [] which is what we want when setting values into state.

Can you please update this, as well as all the other flatten functions to

Suggested change

var output []InboundIpRuleModel

output := make([]InboundIpRuleModel, 0)

stephybun · 2024-11-19T07:47:22Z

internal/services/eventgrid/eventgrid_namespace_resource_test.go

+`, data.RandomInteger, data.Locations.Primary)
+}
+
+func (r EventGridNamespaceResource) basicWithTags(data acceptance.TestData) string {


Minor but we could just call this

Suggested change

func (r EventGridNamespaceResource) basicWithTags(data acceptance.TestData) string {

func (r EventGridNamespaceResource) tags(data acceptance.TestData) string {

stephybun · 2024-11-19T07:47:32Z

internal/services/eventgrid/eventgrid_namespace_resource_test.go

+`, data.RandomInteger, data.Locations.Primary)
+}
+
+func (r EventGridNamespaceResource) basicWithTagsUpdated(data acceptance.TestData) string {


Likewise

Suggested change

func (r EventGridNamespaceResource) basicWithTagsUpdated(data acceptance.TestData) string {

func (r EventGridNamespaceResource) tagsUpdated(data acceptance.TestData) string {

catriona-m · 2024-11-19T17:01:04Z

Thanks @catriona-m. A few more minor comments, but other than that this LGTM provided the tests are passing!

Thanks @stephybun - the tests are passing so going to merge this now 👍

github-actions · 2024-12-20T02:14:19Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

add azurerm_eventgrid_namespace as a new resource

e868a3e

github-actions bot added documentation dependencies service/event-grid EventGrid size/XL waiting-response labels Oct 17, 2024

lint

0ca4808

catriona-m marked this pull request as draft October 17, 2024 14:57

github-actions bot removed the waiting-response label Oct 17, 2024

rcskosir added the new-resource label Oct 17, 2024

catriona-m added 2 commits October 25, 2024 13:36

fix topicSpacesConfig

e080e96

lint

e2a0c30

github-actions bot added waiting-response and removed waiting-response labels Oct 25, 2024

catriona-m marked this pull request as ready for review October 25, 2024 14:48

catriona-m requested review from katbyte and a team as code owners October 25, 2024 14:48

stephybun requested changes Oct 29, 2024

View reviewed changes

github-actions bot added the waiting-response label Oct 29, 2024

add validations, update tags test

d8a8ed9

github-actions bot removed the waiting-response label Nov 8, 2024

remove zone_redundant

eaa205b

stephybun approved these changes Nov 19, 2024

View reviewed changes

Merge branch 'main' into cm/eventgridnamespace

6a89559

github-actions bot added the waiting-response label Nov 19, 2024

make fmt

d3fa68d

github-actions bot added waiting-response and removed waiting-response labels Nov 19, 2024

lint

0f1a3ac

github-actions bot added waiting-response and removed waiting-response labels Nov 19, 2024

update test name and lint

14f9d11

github-actions bot removed the waiting-response label Nov 19, 2024

catriona-m merged commit 780ebd8 into main Nov 19, 2024
33 checks passed

catriona-m deleted the cm/eventgridnamespace branch November 19, 2024 17:13

github-actions bot added this to the v4.11.0 milestone Nov 19, 2024

catriona-m added a commit that referenced this pull request Nov 19, 2024

Update CHANGELOG.md #27682

a6a3053

github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_eventgrid_namespace` #27682

New Resource: `azurerm_eventgrid_namespace` #27682

catriona-m commented Oct 17, 2024 •

edited

Loading

stephybun left a comment

stephybun Oct 29, 2024

catriona-m Nov 11, 2024

stephybun Oct 29, 2024

stephybun Oct 29, 2024

stephybun Oct 29, 2024

stephybun Oct 29, 2024

stephybun Oct 29, 2024

stephybun Oct 29, 2024

stephybun Oct 29, 2024

sbugalski commented Nov 4, 2024 •

edited

Loading

stephybun left a comment

stephybun Nov 19, 2024 •

edited

Loading

stephybun Nov 19, 2024

stephybun Nov 19, 2024

catriona-m commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024


		* `location` - (Required) Specifies the supported Azure location where the resource should exist. Changing this forces a new resource to be created.

		* `capacity` - (Optional) (Optional) Specifies the Capacity / Throughput Units for an Eventgrid Namespace. Valid values can be between `1` and `40`.

	* `capacity` - (Optional) (Optional) Specifies the Capacity / Throughput Units for an Eventgrid Namespace. Valid values can be between `1` and `40`.
	* `capacity` - (Optional) Specifies the Capacity / Throughput Units for an Eventgrid Namespace. Valid values can be between `1` and `40`.


		* `alternative_authentication_name_source` - (Optional) Specifies a list of alternative sources for the client authentication name from the client certificate. Possible values are `ClientCertificateDns`, `ClientCertificateEmail`, `ClientCertificateIp`, `ClientCertificateSubject` and `ClientCertificateUri`.

		* `maximum_client_sessions_per_authentication_name` - (Optional) Specifies the maximum number of client sessions epr authentication name. Valid values can be between `1` and `100`.


		* `maximum_session_expiry_in_hours` - (Optional) Specifies the maximum session expiry interval allowed for all MQTT clients connecting to the Event Grid namespace. Valid values can be between `1` and `8`.

		* `route_topic_id` - (Optional) Specifies the Event Grid topic resource id to route messages to.

	var output []InboundIpRuleModel
	output := make([]InboundIpRuleModel, 0)

	func (r EventGridNamespaceResource) basicWithTags(data acceptance.TestData) string {
	func (r EventGridNamespaceResource) tags(data acceptance.TestData) string {

New Resource: azurerm_eventgrid_namespace #27682

New Resource: azurerm_eventgrid_namespace #27682

Conversation

catriona-m commented Oct 17, 2024 • edited Loading

Community Note

Description

PR Checklist

Testing

Change Log

Related Issue(s)

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbugalski commented Nov 4, 2024 • edited Loading

stephybun left a comment

Choose a reason for hiding this comment

stephybun Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catriona-m commented Nov 19, 2024 • edited Loading

github-actions bot commented Dec 20, 2024

New Resource: `azurerm_eventgrid_namespace` #27682

New Resource: `azurerm_eventgrid_namespace` #27682

catriona-m commented Oct 17, 2024 •

edited

Loading

sbugalski commented Nov 4, 2024 •

edited

Loading

stephybun Nov 19, 2024 •

edited

Loading

catriona-m commented Nov 19, 2024 •

edited

Loading