azurerm_fluid_relay_server - add support for customer_managed_key
#27581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephybun
requested changes
Oct 15, 2024
| customerManagedKey.KeyVaultKeyID = pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyUrl) | ||
| } | ||
| if input.CustomerManagedKeyEncryption.KeyEncryptionKeyIdentity != nil && input.CustomerManagedKeyEncryption.KeyEncryptionKeyIdentity.UserAssignedIdentityResourceId != nil { | ||
| customerManagedKey.UserAssignedIdentityId = pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyIdentity.UserAssignedIdentityResourceId) |
There was a problem hiding this comment.
We might want to parse the user assigned identity that we're getting back from the API here so that we can catch any casing inconsistencies
Suggested change
| customerManagedKey.UserAssignedIdentityId = pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyIdentity.UserAssignedIdentityResourceId) | |
| if v := pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyIdentity.UserAssignedIdentityResourceId); v != "" { | |
| id, err := commonids.ParseUserAssignedIdentity(v) | |
| if err != nil { | |
| return err | |
| } | |
| customerManagedKey.UserAssignedIdentityId = id.ID() | |
| } |
| customerManagedKey := CustomerManagedKey{} | ||
|
|
||
| if input.CustomerManagedKeyEncryption.KeyEncryptionKeyUrl != nil { | ||
| customerManagedKey.KeyVaultKeyID = pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyUrl) |
stephybun
approved these changes
Oct 16, 2024
| if v := pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyIdentity.UserAssignedIdentityResourceId); v != "" { | ||
| id, err := commonids.ParseUserAssignedIdentityID(v) | ||
| if err != nil { | ||
| return []CustomerManagedKey{}, err |
There was a problem hiding this comment.
Same here
Suggested change
| return []CustomerManagedKey{}, err | |
| return nil, err |
| if v := pointer.From(input.CustomerManagedKeyEncryption.KeyEncryptionKeyURL); v != "" { | ||
| id, err := commonids.ParseKeyVaultID(v) | ||
| if err != nil { | ||
| return []CustomerManagedKey{}, err |
There was a problem hiding this comment.
Since we're error'ing here we should return nil instead of data that is valid
Suggested change
| return []CustomerManagedKey{}, err | |
| return nil, err |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Description
This PR adds support for encryption through a
customer_managed_keyPR Checklist
For example: “
resource_name_here- description of change e.g. adding propertynew_property_name_here”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_fluid_relay_server- add support forcustomer_managed_key[GH-00000]This is a (please select all that apply):
Related Issue(s)
Fixes #0000
Note
If this PR changes meaningfully during the course of review please update the title and description as required.