Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_certificate - support for versionless key_vault_secret_id #27537

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

catriona-m
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

=== RUN TestAccAppServiceCertificate_KeyVaultIdVersionless
=== PAUSE TestAccAppServiceCertificate_KeyVaultIdVersionless
=== CONT TestAccAppServiceCertificate_KeyVaultIdVersionless
--- PASS: TestAccAppServiceCertificate_KeyVaultIdVersionless (883.93s)
PASS

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_app_service_certificate - support for versionless key_vault_secret_id [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #23237

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@catriona-m catriona-m requested a review from a team September 30, 2024 14:40
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @catriona-m - LGTM 👍

@catriona-m catriona-m merged commit a5f1b72 into main Oct 3, 2024
29 checks passed
@catriona-m catriona-m deleted the cm/apppcertversionless branch October 3, 2024 15:12
@github-actions github-actions bot added this to the v4.4.0 milestone Oct 3, 2024
catriona-m added a commit that referenced this pull request Oct 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_service_certificate can't reference azurerm_key_vault_certificate versionless secret ID
2 participants