[fix] Correctly setreplica_server_id on azurerm_postgresql_flexible_server_virtual_endpoint forazurerm_postgresql_flexible_servers that exist in separate resource groups

[bruceharrison1984]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This corrects a bug that occurs when the replica server doesn't exist in the same resource group as the source server. Previously, the endpoint would be flagged for changes on the second run. This corrects that issue.

Additionally, if the primary server was stopped it would also try to recreate the virtual endpoint. This also corrects that issue.

Anyone previously affected by this will see non-destructive changes on the first deploy, but the issue should correct it self there after.

This PR also removes the custom poller that was previously necessary. It appears Azure has changed the API so it is no longer necessary.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_postgresql_flexible_server_virtual_endpoint - fix bug that affected replicas deployed in different resource groups from the source server [postgresql_flexible_server_virtual_endpoint_resource incorrectly sets Replica Server ID #27453]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #27453
Fixes #27749

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Hi @bruceharrison1984 - Thanks for this PR, it looks mostly good, but there are a few minor changes to take a look at below if you could?
Thanks

[jackofallops]

Are the server names we're looking for here guaranteed to be unique per subscription, or could we have a condition where there are multiple servers of the same name in different resource groups that could lead to an unexpected outcome here?

[bruceharrison1984]

The names may not be unique per subscription, however they must be unique per source server. Since we check that the replica name matches, as well as filter those results based on the source server ID we should be protected from selecting an incorrect replica. Even if the names matched, replicas must have unique names per source servers.

TLDR; For a given source server, all replicas associated with the source server must have unique names. By filtering on both conditions, we can confidently pick the correct one even if duplicate named replicas exist within the subscription.

https://github.com/hashicorp/terraform-provider-azurerm/pull/27509/files/94e28c5de14955a188f90192c06828946f9a6fcc#diff-6fceca959b7c5669ebd391456b3a69c7ff858802d5dc5e70a91c6237cd173ff0R258

I was worried about this as well, but I believe it is setup in a safe manner.

[jackofallops]

Since this is direct from the lookup API, we can't be sure it will be correctly cased for the expected state (since we validate the input), can we normalise it using servers.ParseFlexibleServerID() before setting the value into state.ReplicaServerId?

[bruceharrison1984]

I've updated the code to reflect your suggestion

[leonrob]

From a hashi customer... THANK YOU FOR THIS @bruceharrison1984

[leonrob]

Hi can this be released this week? @jackofallops I think @bruceharrison1984 left Hashicorp recently. Someone else may need to push this

[leonrob]

will this be released soon?

[stephybun]

Thanks for this @bruceharrison1984. Hope you don't mind I pushed some minor simplifications and additional nil checks to your code.

Tests are passing, LGTM 🚀

[bruceharrison1984]

@stephybun I've got no complaints with someone improving the codebase, and showing me a better way.

Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.