azurerm_storage_blob - source is no longer ForceNew / azurerm_storage_object_replication - rules.x. source_container_name and rules.x. destination_container_name are no longer ForceNew
#27394
Conversation
| @@ -207,13 +207,6 @@ func TestAccStorageShare_accessTierStandard(t *testing.T) { | |||
| ), | |||
| }, | |||
| data.ImportStep(), | |||
| { | |||
There was a problem hiding this comment.
TestAccStorageShare_accessTierStandard had a step removed as we're checking if access tier can be updated twice but once you change it, it takes forever to change again. I added a RetryableError but it takes an unknown amount of time to be updatable again so it's worth removing that second update.
| @@ -66,14 +66,12 @@ func resourceStorageObjectReplication() *pluginsdk.Resource { | |||
| "source_container_name": { | |||
| Type: pluginsdk.TypeString, | |||
| Required: true, | |||
| ForceNew: true, | |||
There was a problem hiding this comment.
These ForceNews aren't needed anymore. I checked to make sure that it didn't cause issues with this resource by updating them to different things and Azure accepted them just fine
| storage_share_id = azurerm_storage_share.test.id | ||
|
|
||
|
|
||
| content_type = "test_content_type" | ||
| content_encoding = "test_encoding" | ||
| content_disposition = "test_content_disposition" | ||
| content_md5 = "1234567890abcdef1234567890abcdef" |
There was a problem hiding this comment.
This attribute can't be updated and we use it in another test so it should be ok to remove here
mbfrahry
changed the title
tests - fixes for storageazurerm_storage_blob - source is no longer ForceNew / azurerm_storage_object_replication - rules.x. source_container_name and rules.x. destination_container_name are no longer ForceNew
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR has various test fixes for storage that include removing ForceNew from certain attributes, adding 404 checks, and Retryable Errors.