New Data Source : azurerm_vpn_server_configuration

[sinbai]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Support for a azurerm_vpn_server_configuration data source.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

PASS: TestAccVPNServerConfigurationDataSource_azureAD (289.43s)
PASS: TestAccVPNServerConfigurationDataSource_certificate (228.86s)
PASS: TestAccVPNServerConfigurationDataSource_radius (225.54s)
PASS: TestAccVPNServerConfigurationDataSource_tags (210.99s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• New Data Source : azurerm_vpn_server_configuration [Support for a azurerm_vpn_server_configuration datasource #26989]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26989

[stephybun]

Thanks @sinbai, please see the comment left in-line

[stephybun]

@sinbai we're not accepting new untyped resource or data sources. Can you please convert this to a typed data source before we proceed with the review here?

[sinbai]

Fixed.

[sinbai]

Thanks @sinbai, please see the comment left in-line

Hi @stephybun thanks for your time and feedback. I have updated the code and retested the results as follows, could you please take another look?

[katbyte]

LGTM 🌷

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.