Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_role_assignment: fix import when use role name instead of id #2565

Merged
merged 2 commits into from
Dec 23, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 21, 2018

attempt to fix:

        --- PASS: TestAccAzureRMRoleAssignment/basic/custom (42.86s)
        --- PASS: TestAccAzureRMRoleAssignment/basic/builtin (32.28s)
        --- FAIL: TestAccAzureRMRoleAssignment/basic/roleName (23.27s)
        	testing.go:538: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        		
        		(map[string]string) {
        		}
        		
        		
        		(map[string]string) (len=1) {
        		 (string) (len=20) "role_definition_name": (string) (len=20) "Log Analytics Reader"
        		}

@katbyte katbyte added this to the 1.21.0 milestone Dec 21, 2018
@ghost ghost added the size/S label Dec 21, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Tests pass:

screenshot 2018-12-23 at 14 56 28

@tombuildsstuff tombuildsstuff merged commit cb345fb into master Dec 23, 2018
@tombuildsstuff tombuildsstuff deleted the roles/assingment-by-name branch December 23, 2018 14:57
tombuildsstuff added a commit that referenced this pull request Dec 23, 2018
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants