Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DataSource: azurerm_monitor_action_group #2430

Merged
merged 3 commits into from
Dec 4, 2018
Merged

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Dec 3, 2018

In this PR, I introduced azurerm_monitor_action_group data source, which contains identical attributes as the corresponding resource.

This PR also fulfills our community request #2323.

(fixes #2323)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JunyiYi,

Thank you for this PR, LGTM 👍

@katbyte
Copy link
Collaborator

katbyte commented Dec 4, 2018

Tests pass:
screen shot 2018-12-03 at 17 32 17

@katbyte katbyte merged commit abbafa9 into master Dec 4, 2018
@katbyte katbyte added this to the 1.20.0 milestone Dec 4, 2018
katbyte added a commit that referenced this pull request Dec 4, 2018
@katbyte katbyte deleted the datasource_actiongroup branch December 4, 2018 01:34
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing to fix up but this otherwise LGTM if the tests pass 👍


# Data Source: azurerm_monitor_action_group

Use this data source to access the properties of an Action Group.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an Action Group. -> an existing Action Group.

@andyredhead-adv365
Copy link

Just gave this a go - works perfectly, thanks :)

@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_monitor_action_group data source
5 participants